fix: Update argument names as per Fluent change. #4752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates argument names in PyFluent to align with changes made in Fluent 26.1, where the list-properties command's parameter naming was modified. The changes remove workarounds that were previously necessary to handle parameter name conflicts.
Key Changes:
- Updated
list_propertiesmethod to use the newobject_pathparameter instead of the previouspath_1andnameparameters - Removed the workaround logic in
execute_cmdthat renamedpath_1topath - Added PyFluent version tracking to the Fluent version information output
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ansys/fluent/core/solver/flobject.py | Updated list_properties to use new object_path parameter with concatenated path |
| src/ansys/fluent/core/services/settings.py | Removed path_1 to path parameter renaming workaround from execute_cmd |
| src/ansys/fluent/core/codegen/print_fluent_version.py | Added PyFluent version output to version information file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seanpearsonuk
approved these changes
Dec 17, 2025
prmukherj
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Argument name of global list-properties command has been changed in Fluent during 26.1 (PR 620650). This results in inconsistent behavior in PyFluent.
Corresponding Fluent bug - 1385223
Change Summary
Update argument names in PyFluent as per latest Fluent code.
Rationale
list-properties should be called with correct argument names from PyFluent.
Impact
Fix inconsistent behavior, unintended warnings.