fix: resolve the right config file and args from cli #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🙏 |
antfu
reviewed
Mar 3, 2024
src/config.ts
Outdated
Comment on lines
20
to
23
| const childrenNames = readdirSync(cwd) | ||
| const name = childrenNames.some(name => name.includes('bumpp')) ? 'bumpp' : 'bump' | ||
| const { config } = await loadConfig<VersionBumpOptions>({ | ||
| name: 'bump', | ||
| name, |
Member
There was a problem hiding this comment.
I don't think this is a good idea to rely on readdirSync, as the config can come from different sources. Instead we could run c12 twice and merge the config.
antfu
reviewed
Mar 4, 2024
| cwd = process.cwd(), | ||
| ) { | ||
| const { config: bumppConfig } = await loadConfig<VersionBumpOptions>({ | ||
| name: 'bumpp', |
Member
There was a problem hiding this comment.
After a second thought, I think it's better to only read from bump to avoid confusion, as we already fix the docs for quite a while now.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two fixes.
The first is that the document here says that the config name is
bumpp.config.ts, but the name is actuallybump.config.ts. Maybe it's better to support both of the names? This will fix #6.And because of adding the
--no-commitand--no-tagoptions inv9.2.0, this will set thecommitandtagfrom cli args totrueinstead ofundefinedaccording to https://github.com/cacjs/cac#negated-options. And this will overrides the config from config file. I made some fixes so it can now read the right args from cli. This will fix #13 and #19.Linked Issues
#6 #13 #19
Additional context