fix: allow @ character in branch name validation#999
Open
msyed-godaddy wants to merge 1 commit intoanthropics:mainfrom
Open
fix: allow @ character in branch name validation#999msyed-godaddy wants to merge 1 commit intoanthropics:mainfrom
msyed-godaddy wants to merge 1 commit intoanthropics:mainfrom
Conversation
The branch name validation regex rejected @ characters, but @ is a
valid character in git branch names. Many workflows use @ in branch
names (e.g., TICKET-123@add-feature). The dangerous @{ sequence is
already caught by a separate check, so allowing @ in the whitelist
regex is safe.
Fixes anthropics#998
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
very similar to #956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@in branch names@character is valid in git branch names and commonly used in workflows (e.g.,TICKET-123@add-feature)@{sequence (git reflog syntax) is already caught by a separate dedicated check, so allowing@in the whitelist regex is safe@Fixes #998
Test plan
@in branch names (TICKET-123@add-feature,user@feature-branch,feature@v2)@{rejection test still passes (caught by the separate@{check)TICKET-123@add-featureno longer cause validation errors🤖 Generated with Claude Code