Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"scripts": {
"clean": "rimraf target buildcache docs coverage",
"lint:fix": "yarn lint --fix",
"lint:fix": "eslint -c src/test/lint/.eslintrc.json src --fix",
"format": "prettier --write \"src/**/*.ts\"",
"test": "concurrently 'npm:test:*'",
"test:unit": "NODE_OPTIONS=\"--experimental-vm-modules\" jest --config=jest.config.json --runInBand",
Expand Down
2 changes: 1 addition & 1 deletion src/main/ts/stages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
/**
* Resolve bins.
*/
export const resolveBins: TCallback = ({ ctx, temp, flags }) => {
export const resolveBins: TCallback = ({ ctx, flags }) => {
const yafManifest = getSelfManifest()
ctx.bins = {
yarn: getYarn(),
Expand Down
2 changes: 1 addition & 1 deletion src/main/ts/util.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { StdioOptions } from 'node:child_process'
import crypto from 'node:crypto'
import { createRequire } from 'node:module'
import path, { dirname, join, resolve } from 'node:path'
import path, { dirname, resolve } from 'node:path'
import { fileURLToPath } from 'node:url'
import os from 'node:os'

Expand Down
2 changes: 1 addition & 1 deletion src/test/lint/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"rules": {},
"overrides": [
{
"files": ["src/test/ts/runner.ts", "src/main/ts/stages.ts"],
"files": ["src/test/ts/runner.ts", "src/main/ts/stages.ts", "src/test/ts/util.ts"],
"rules": {
"sonarjs/no-duplicate-string": "off",
"@typescript-eslint/ban-ts-comment": "off"
Expand Down
6 changes: 3 additions & 3 deletions src/test/ts/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,14 @@ describe('util', () => {
],
[{ exclude: [] }, ['exclude'], []],
[
{ exclude: ['@scope/package'] }, // eslint-disable-line sonarjs/no-duplicate-string
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO @scope/package is fine. Let's add test/ts/util.ts to the rule exclusions instead.
https://github.com/antongolub/yarn-audit-fix/blob/master/src/test/lint/.eslintrc.json#L6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 13c91de

{ exclude: ['@scope/package'] },
['exclude'],
['--exclude', '@scope/package'],
],
[
{ exclude: ['@scope/package', 'another-package'] },
{ exclude: ['@scope/package1', 'package2'] },
['exclude'],
['--exclude', '@scope/package', '--exclude', 'another-package'],
['--exclude', '@scope/package1', '--exclude', 'package2'],
],
[{ verbose: true, exclude: [] }, [], ['--verbose']],
]
Expand Down