Skip to content

Cleanup - ProgramRuntimeEnvironments#11080

Open
Lichtso wants to merge 1 commit intoanza-xyz:masterfrom
Lichtso:cleanup/program_runtime_environments
Open

Cleanup - ProgramRuntimeEnvironments#11080
Lichtso wants to merge 1 commit intoanza-xyz:masterfrom
Lichtso:cleanup/program_runtime_environments

Conversation

@Lichtso
Copy link

@Lichtso Lichtso commented Mar 6, 2026

Problem

ProgramRuntimeEnvironments::program_runtime_v2 is unused in the entire code base.

Summary of Changes

Renames:

  • get_mock_env() => get_mock_program_runtime_environment()
  • create_program_runtime_environment_v1() => create_program_runtime_environment()
  • morph_into_deployment_environment_v1() => morph_into_deployment_environment()
  • program_runtime_environments_for_execution() => program_runtime_environment_for_execution()
  • program_runtime_environments_for_deployment() => program_runtime_environment_for_deployment()
  • get_program_runtime_environments_for_execution() => get_program_runtime_environment_for_execution()
  • get_program_runtime_environments_for_deployment() => get_program_runtime_environment_for_deployment()
  • get_environments_for_epoch() => program_runtime_environment_for_epoch()
  • set_environments() => set_program_runtime_environment()
  • EpochBoundaryPreparation::upcoming_environments => EpochBoundaryPreparation::upcoming_environment
  • TransactionBatchProcessor::environments => TransactionBatchProcessor::program_runtime_environment

Refactors:

  • ProgramRuntimeEnvironments::program_runtime_v1 => ProgramRuntimeEnvironment
  • program_runtime_environment: Arc::new(BuiltinProgram::new_loader(VmConfig::default()))

Removes:

  • ProgramRuntimeEnvironments
  • get_mock_program_runtime_environments()

@mergify
Copy link

mergify bot commented Mar 6, 2026

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the cleanup/program_runtime_environments branch 6 times, most recently from 9faa377 to 8fafe4d Compare March 6, 2026 19:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 98.96907% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (9361652) to head (158215f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #11080     +/-   ##
=========================================
- Coverage    83.1%    83.1%   -0.1%     
=========================================
  Files         837      837             
  Lines      316652   316592     -60     
=========================================
- Hits       263178   263096     -82     
- Misses      53474    53496     +22     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lichtso Lichtso force-pushed the cleanup/program_runtime_environments branch from d012a23 to 158215f Compare March 10, 2026 23:58
@Lichtso Lichtso marked this pull request as ready for review March 11, 2026 09:44
@Lichtso Lichtso requested a review from a team as a code owner March 11, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants