Skip to content

cleanup(blockstore): remove migration fallback for Index#11152

Open
kskalski wants to merge 4 commits intoanza-xyz:masterfrom
kskalski:ks/cleanup_blockstore_index
Open

cleanup(blockstore): remove migration fallback for Index#11152
kskalski wants to merge 4 commits intoanza-xyz:masterfrom
kskalski:ks/cleanup_blockstore_index

Conversation

@kskalski
Copy link

@kskalski kskalski commented Mar 10, 2026

Problem

#8459 enabled migration to CompletedDataIndexesV2 (contained in SlotMetaV2) and ShredIndexV2 (contained in IndexV2) which switched to serializing indices as fixed size bit-vec instead of using btree-set (which on the wire generates shorter integer lists).
Post 4.0 we don't need the old btree-set code that generates old format, it's enough that current bit-vec can understand it (that part could also be removed post 4.1).

This means CompletedDataIndexesV1, ShredIndexV2 and related structs can be removed.

This PR also removes the fallback deserialization code for supporting migrations of blockstore_meta::Index and blockstore_meta::SlotMeta columns - we could potentially keep it, but I think it's uncertain if any future migration could re-use it as-is, so for the sake of simplification it's better to cut it and re-create if we ever need it.

Summary of Changes

  • remove IndexV1, ShredIndexV1, CompletedDataIndexesV1, SlotMetaV1
  • rename CompletedDataIndexesV2 to CompletedDataIndexes, SlotMetaV2 to SlotMeta, ShredIndexV2 to ShredIndex, IndexV2 to Index
  • still keep custom BitVec deserialization that supports data emitted by CompletedDataIndexesV1
  • remove fallback deserialization that checked two formats

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (f41a763) to head (9091b48).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11152    +/-   ##
========================================
  Coverage    83.1%    83.1%            
========================================
  Files         837      837            
  Lines      316652   317070   +418     
========================================
+ Hits       263170   263615   +445     
+ Misses      53482    53455    -27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski marked this pull request as ready for review March 10, 2026 09:45
@kskalski kskalski requested a review from cpubot March 10, 2026 09:45
@kskalski kskalski marked this pull request as draft March 10, 2026 09:52
@kskalski kskalski removed the request for review from cpubot March 10, 2026 09:52
@kskalski kskalski force-pushed the ks/cleanup_blockstore_index branch from e5caada to 9091b48 Compare March 11, 2026 01:52
@kskalski kskalski marked this pull request as ready for review March 11, 2026 02:49
@kskalski kskalski requested review from cpubot and steviez March 11, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants