cleanup(blockstore): remove migration fallback for Index#11152
Open
kskalski wants to merge 4 commits intoanza-xyz:masterfrom
Open
cleanup(blockstore): remove migration fallback for Index#11152kskalski wants to merge 4 commits intoanza-xyz:masterfrom
kskalski wants to merge 4 commits intoanza-xyz:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11152 +/- ##
========================================
Coverage 83.1% 83.1%
========================================
Files 837 837
Lines 316652 317070 +418
========================================
+ Hits 263170 263615 +445
+ Misses 53482 53455 -27 🚀 New features to boost your workflow:
|
e5caada to
9091b48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#8459 enabled migration to
CompletedDataIndexesV2(contained inSlotMetaV2) andShredIndexV2(contained inIndexV2) which switched to serializing indices as fixed size bit-vec instead of using btree-set (which on the wire generates shorter integer lists).Post 4.0 we don't need the old btree-set code that generates old format, it's enough that current bit-vec can understand it (that part could also be removed post 4.1).
This means
CompletedDataIndexesV1,ShredIndexV2and related structs can be removed.This PR also removes the fallback deserialization code for supporting migrations of
blockstore_meta::Indexandblockstore_meta::SlotMetacolumns - we could potentially keep it, but I think it's uncertain if any future migration could re-use it as-is, so for the sake of simplification it's better to cut it and re-create if we ever need it.Summary of Changes
IndexV1,ShredIndexV1,CompletedDataIndexesV1,SlotMetaV1CompletedDataIndexesV2toCompletedDataIndexes,SlotMetaV2toSlotMeta,ShredIndexV2toShredIndex,IndexV2toIndexBitVecdeserialization that supports data emitted byCompletedDataIndexesV1