Removes holding storages in AccountsHashVerifier for fastboot #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
========================================
Coverage 81.8% 81.9%
========================================
Files 838 837 -1
Lines 226389 226239 -150
========================================
- Hits 185342 185301 -41
+ Misses 41047 40938 -109 |
brooksprumo
force-pushed
the
fastboot/no-fastboot-storages
branch
from
c6f77de to
414e34f
Compare
apfitzge
approved these changes
Mar 11, 2024
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
Change lgtm - no risk of append-vecs being rugged by recycling simplifies things greatly!
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that the recycler has been removed (#118), AccountsHashVerifier no longer needs to hold onto an Arc of the fastboot storages to prevent them from being recycled.
Summary of Changes
Remove holding storages in AccountsHashVerifier for fastboot
Fixes solana-labs#35431 and solana-labs#35376
Note, the first commit reverts #58, and the second commit removes holding the storages in AHV. Reviewing by commit may be easier.
I tested this PR using the same procedure as from #58.