Skip to content

Conversation

@jstarry
Copy link

@jstarry jstarry commented Mar 8, 2024

Problem

Solana prefix is still being used for pre-installed binaries and this breaks net.sh deploys

Summary of Changes

Use agave prefix where necessary

Fixes #

@jstarry jstarry requested a review from yihau March 8, 2024 16:19
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed them 😢 thank you 🫶

@jstarry jstarry added the automerge automerge Merge this Pull Request automatically once CI passes label Mar 8, 2024
@mergify mergify bot merged commit 68be105 into anza-xyz:master Mar 8, 2024
@jstarry jstarry deleted the fix/net-scripts branch March 9, 2024 01:18
@mergify
Copy link

mergify bot commented Mar 21, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link

mergify bot commented Mar 21, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Mar 21, 2024
mergify bot pushed a commit that referenced this pull request Mar 21, 2024
yihau pushed a commit that referenced this pull request Mar 21, 2024
… binaries (backport of #155) (#349)

Use agave prefix in scripts for pre-installed binaries (#155)

(cherry picked from commit 68be105)

Co-authored-by: Justin Starry <[email protected]>
yihau pushed a commit that referenced this pull request Mar 21, 2024
… binaries (backport of #155) (#350)

Use agave prefix in scripts for pre-installed binaries (#155)

(cherry picked from commit 68be105)

Co-authored-by: Justin Starry <[email protected]>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
Aligns with the rest of the process better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants