Skip to content

Conversation

@yihau
Copy link
Member

@yihau yihau commented Mar 11, 2024

Problem

the Windows artifacts doesn't upload to the gh release page

Summary of Changes

use the correct download path

@mergify
Copy link

mergify bot commented Mar 11, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link

mergify bot commented Mar 11, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@yihau yihau merged commit 3863bb1 into anza-xyz:master Mar 11, 2024
@yihau yihau deleted the fix-windows-gh-release branch March 11, 2024 04:29
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
yihau added a commit that referenced this pull request Mar 11, 2024
yihau added a commit that referenced this pull request Mar 11, 2024
yihau added a commit that referenced this pull request Mar 12, 2024
… of #165) (#166)

ci: fix Windows gh release pipeline (#165)

(cherry picked from commit 3863bb1)

Co-authored-by: Yihau Chen <[email protected]>
yihau added a commit that referenced this pull request Mar 12, 2024
… of #165) (#167)

ci: fix Windows gh release pipeline (#165)

(cherry picked from commit 3863bb1)

Co-authored-by: Yihau Chen <[email protected]>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
As CI will stop on the first error, this simplifies debugging as in most
cases the output will contain a more verbose error description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants