Fix pubkey formatter #256
Closed
Fix pubkey formatter #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always use "{}". This commit fix it by using the fmt from the argument
to format the string.
HaoranYi
changed the title
fmt it always use "{}". This commit fix it by using the fmt from the argument to format the string.
t-nelson
reviewed
Mar 15, 2024
sdk/program/src/pubkey.rs
Outdated
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| write!(f, "{}", bs58::encode(self.0).into_string()) | ||
| let _ = bs58::encode(self.0).into_string().fmt(f); | ||
| write!(f, "") |
Author
There was a problem hiding this comment.
Ah. Good catch. We don't need this. It was removed in the recent commit.
added 2 commits
March 15, 2024 14:31
|
This PR contains changes to the solana sdk, which will be moved to a new repo within the next week, when v2.2 is branched from master. Please merge or close this PR as soon as possible, or re-create the sdk changes when the new repository is ready at https://github.com/anza-xyz/solana-sdk |
t-nelson
reviewed
Feb 4, 2025
Comment on lines
+996
to
+997
| /// 1111111QLbz7JHiBTspS962RLKV8GndWFwiEaqKM (before) | ||
| /// 1111111QLbz7JHiBTspS962RLKV8GndWFwiEaqKMxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx (this pr) |
There was a problem hiding this comment.
comments don't really make sense post-merge. this kind of commentary belongs in pr description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per #241
pubkey display didn't honor user supplied format string. Inside
fmt, it always use "{}". This commit fix it by using the fmt from the argument to format the string.We probably should do this for all other user customized type formatter.
Summary of Changes
Fixes #