vote: deprecate unused legacy vote tx plumbing #274
Conversation
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
AshwinSekar
added
the
automerge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 837 837
Lines 226793 226812 +19
=========================================
- Hits 185830 185825 -5
- Misses 40963 40987 +24 |
(cherry picked from commit b27c80a) # Conflicts: # sdk/src/feature_set.rs
(cherry picked from commit b27c80a) # Conflicts: # sdk/src/feature_set.rs
…) (#275) * vote: deprecate unused legacy vote tx plumbing (#274) (cherry picked from commit b27c80a) # Conflicts: # sdk/src/feature_set.rs * fix conflicts --------- Co-authored-by: Ashwin Sekar <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
…) (#276) * vote: deprecate unused legacy vote tx plumbing (#274) (cherry picked from commit b27c80a) # Conflicts: # sdk/src/feature_set.rs * fix conflicts --------- Co-authored-by: Ashwin Sekar <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
AshwinSekar
added
the
feature-gate
…za-xyz#274) (anza-xyz#276) * vote: deprecate unused legacy vote tx plumbing (anza-xyz#274) (cherry picked from commit b27c80a) # Conflicts: # sdk/src/feature_set.rs * fix conflicts --------- Co-authored-by: Ashwin Sekar <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
) Previous changes that changed `cargo check` to `cargo check --tests` were incorrect, as `cargo check --tests` means check only tests. `cargo check`is equivalent to`cargo check --lib --bins`. So adding all the arguments provides more coverage. Ideally, we should be saying `cargo check --all-targets`, which adds `--benches` into the mix. But some of our benchmarks are currently written such that they only compile on a nightly compiler. Should we fix that, we can then move to `cargo check --all-targets`.
3 participants
start cleaning up some plumbing