Move remaining bits; partitioned epoch-rewards reorg, 5 of 5 #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 848 849 +1
Lines 229160 229163 +3
=========================================
- Hits 187547 187537 -10
- Misses 41613 41626 +13 |
CriesofCarrots
force-pushed
the
simd-118-other-sub
branch
from
8298b75 to
dd10965
Compare
CriesofCarrots
force-pushed
the
simd-118-other-sub
branch
from
dd10965 to
93455a1
Compare
Author
|
There are a few distinct pieces to this one. I lumped them together because they are all relatively small, but let me know if you prefer this to be split up. |
joncinque
approved these changes
Apr 3, 2024
CriesofCarrots
force-pushed
the
simd-118-other-sub
branch
from
93455a1 to
d2a9830
Compare
Author
|
Rebased to pick up cargo audit fix |
|
It looks like the rebase didn't dismiss my review, which is... good? |
Author
🤷♀️ It is definitely unexpected to me! I suppose it's convenient, though. |
CriesofCarrots
added
the
automerge
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code for partitioned epoch rewards is peppered throughout bank.rs. It is very hard to trace the flows, and figure out which structs and methods are needed for calculation vs distribution, or for sysvar handling.
Summary of Changes
Moves epoch_rewards_hasher runtime functionality and associated unit tests into
partitioned_epoch_rewardssubmoduleMoves integration-like tests into submodule
Moves (test-only) compare functionality into submodule
Best reviewed by commit
This is the last PR refactoring this section of Bank code.
Closes #510