Skip to content

Conversation

@t-nelson
Copy link

@t-nelson t-nelson commented Apr 6, 2024

Problem

#611 attempts to introduce binding sockets with SO_REUSEPORT. this breaks some brittle port allocation logic that assumes bind() with fail for unavailable ports. for those with SO_REUSEPORT set it now succeeds, leading to duplicate allocations.

Summary of Changes

rework bind*in_range helpers from solana_net_utils to work off a shared iterator so ports that are successfully bound are not retried later

@alexpyattaev
Copy link

We will be reworking much of the port binding logic to support multihoming, this will not be applicable (though idea is cool!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants