-
Notifications
You must be signed in to change notification settings - Fork 883
Remove index_in_callee from InstructionAccount
#7263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
========================================
Coverage 83.0% 83.0%
========================================
Files 801 801
Lines 362242 362439 +197
========================================
+ Hits 300807 300987 +180
- Misses 61435 61452 +17 🚀 New features to boost your workflow:
|
index_in_callee from InstructionContextindex_in_callee from InstructionAccount
Problem
In SIMD-0177, we want
InstructionContextto have onlyindex_in_transaction,is_signerandis_writable. We must, then, removeindex_in_callee.Summary of Changes
prepare_next_to_level_instruction, and inprepare_next_instructionfor detecting duplicated accounts and retrieving the index_in_instruction from the index_in_transaction.fn configurenow receives the aforementioned map as an argument, so I cratedfn configure_for_testto facilitate the usage in tests.