accounts db/refactor accounts db test- make combine_ancient_slots and shrink_ancient tests to work for both append-vec and hot-storages #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HaoranYi
force-pushed
the
accounts-db/refactor_accounts_db_test6
branch
4 times, most recently
from
8f301d2 to
bb006ea
Compare
HaoranYi
changed the title
HaoranYi
force-pushed
the
accounts-db/refactor_accounts_db_test6
branch
2 times, most recently
from
2c78523 to
c58455f
Compare
…append-vec and hot-storages.
HaoranYi
force-pushed
the
accounts-db/refactor_accounts_db_test6
branch
from
c58455f to
525f399
Compare
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
make combine_ancient_slots and shrink_ancient tests to work for both append-vec and hot-storages.
[NOTE] Current ancient storage algorithm is tired with shrink. It is based on the max_size of the storage to find candidate ancient slot. But this scheme won't work with HotStorage. We need to revisit the ancient storage algorithm for HotStorage...
Summary of Changes
Fixes #