Skip to content

Conversation

@joncinque
Copy link

@joncinque joncinque commented Apr 23, 2024

Problem

The SPL libraries have been updated to 1.18 and newer, but the monorepo is still using the older libraries.

Summary of Changes

Upgrade them all. The main changes are:

  • token-2022's transfer fee instruction is parsed separately
  • need to import token-2022's new BaseStateWithExtensionsMut trait
  • associated-token-account uses borsh v1
  • patch more crates for downstream builds

Note that we're still using the older version of the built spl-token-2022 because the newest version is still under audit.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (b28792b) to head (50e466f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #994     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         855      855             
  Lines      232167   232219     +52     
=========================================
+ Hits       190209   190235     +26     
- Misses      41958    41984     +26     

CriesofCarrots
CriesofCarrots previously approved these changes Apr 24, 2024
Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling all the downstream stuff! I kind of threw that branch of mine together, and then let it fall by the wayside.

@joncinque
Copy link
Author

Sorry, there was a merge conflict, can I get another approval?

@joncinque
Copy link
Author

CI appears to be failing now with the same error as microsoft/linux-package-repositories#130 -- I'll wait a little bit to see if it gets resolved, otherwise we can add the suggested patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants