Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chido. change up secret handling to be more flexible
  • Loading branch information
gregcusack committed Apr 22, 2024
commit 146a54689d68e5b05e8f394f25f33d365196b779
37 changes: 26 additions & 11 deletions src/k8s_helpers.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
use {
k8s_openapi::{api::core::v1::Secret, ByteString},
kube::api::ObjectMeta,
std::{collections::BTreeMap, error::Error, path::PathBuf},
std::{
collections::{BTreeMap, HashMap},
error::Error,
path::PathBuf,
},
};

fn create_secret(name: &str, data: BTreeMap<String, ByteString>) -> Secret {
pub enum SecretType {
Value { v: String },
File { path: PathBuf },
}

fn build_secret(name: &str, data: BTreeMap<String, ByteString>) -> Secret {
Secret {
metadata: ObjectMeta {
name: Some(name.to_string()),
Expand All @@ -15,18 +24,24 @@ fn create_secret(name: &str, data: BTreeMap<String, ByteString>) -> Secret {
}
}

pub fn create_secret_from_files(
pub fn create_secret(
secret_name: &str,
key_files: &[(PathBuf, &str)], //[pathbuf, key type]
secrets: HashMap<String, SecretType>,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since Secret takes a BTreeMap, you could just pass one in here directly

) -> Result<Secret, Box<dyn Error>> {
let mut data = BTreeMap::new();
for (file_path, key_type) in key_files {
let file_content = std::fs::read(file_path)
.map_err(|err| format!("Failed to read file '{:?}': {}", file_path, err))?;
data.insert(format!("{key_type}.json"), ByteString(file_content));
let mut data: BTreeMap<String, ByteString> = BTreeMap::new();
for (label, value) in secrets {
match value {
SecretType::Value { v } => {
data.insert(label, ByteString(v.into_bytes()));
}
SecretType::File { path } => {
let file_content = std::fs::read(&path)
.map_err(|err| format!("Failed to read file '{:?}': {}", path, err))?;
data.insert(label, ByteString(file_content));
}
}
Comment on lines +31 to +42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you might be able to do this in one statement by collecting into a BTreeMap, ie:

    let data = secrets.into_iter().map(|(label_value)| ... (label, ByteString(v.into_bytes()))).collect::<BTreeMap<_, _>>();

}

Ok(create_secret(secret_name, data))
Ok(build_secret(secret_name, data))
}

pub fn create_selector(key: &str, value: &str) -> BTreeMap<String, String> {
Expand Down
41 changes: 32 additions & 9 deletions src/kubernetes.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
use {
crate::k8s_helpers,
crate::k8s_helpers::{self, SecretType},
k8s_openapi::api::core::v1::{Namespace, Secret},
kube::{
api::{Api, ListParams, PostParams},
Client,
},
std::{collections::BTreeMap, error::Error, path::Path},
std::{
collections::{BTreeMap, HashMap},
error::Error,
path::Path,
},
};

pub struct Kubernetes {
Expand Down Expand Up @@ -43,14 +47,33 @@ impl Kubernetes {
let vote_key_path = config_dir.join("bootstrap-validator/vote-account.json");
let stake_key_path = config_dir.join("bootstrap-validator/stake-account.json");

let key_files = vec![
(faucet_key_path, "faucet"),
(identity_key_path, "identity"),
(vote_key_path, "vote"),
(stake_key_path, "stake"),
];
let mut secrets = HashMap::new();
secrets.insert(
"faucet".to_string(),
SecretType::File {
path: faucet_key_path,
},
);
secrets.insert(
"identity".to_string(),
SecretType::File {
path: identity_key_path,
},
);
secrets.insert(
"vote".to_string(),
SecretType::File {
path: vote_key_path,
},
);
secrets.insert(
"stake".to_string(),
SecretType::File {
path: stake_key_path,
},
);

k8s_helpers::create_secret_from_files(secret_name, &key_files)
k8s_helpers::create_secret(secret_name, secrets)
}

pub async fn deploy_secret(&self, secret: &Secret) -> Result<Secret, kube::Error> {
Expand Down