Skip to content

Add initial integration test code #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foxish merged 22 commits into from
Dec 20, 2017
Merged

Add initial integration test code #3

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e82d4c5
Made test code compile
kimoonkim Dec 15, 2017
7c8612c
Clean up pom.xml
kimoonkim Dec 15, 2017
5a950eb
Unpack distro in place
kimoonkim Dec 16, 2017
b14430e
Clean up redundant resources
kimoonkim Dec 16, 2017
0443af8
Avoid buggy truezip
kimoonkim Dec 16, 2017
567ad3e
Cleaned up docker image builder
kimoonkim Dec 16, 2017
74c158b
Builds some docker images
kimoonkim Dec 16, 2017
bde1cf9
Drop http jar support for now
kimoonkim Dec 16, 2017
8624545
Clean up
kimoonkim Dec 16, 2017
5585a0a
Use spark-submit
kimoonkim Dec 16, 2017
f793e38
Tests pass
kimoonkim Dec 16, 2017
069ae50
Add hacks for dockerfiles and entrypoint.sh
kimoonkim Dec 17, 2017
204c51f
Address review comments
kimoonkim Dec 18, 2017
6a93a9e
Clean up pom.xml
kimoonkim Dec 18, 2017
b3e4ee0
Add instructions in README.md
kimoonkim Dec 18, 2017
989a371
Switch to container.image property keys
kimoonkim Dec 18, 2017
46d1f5f
Define version properies in pom.xml
kimoonkim Dec 18, 2017
5f88921
Fix a bug in pom.xml
kimoonkim Dec 19, 2017
a68bd5f
Clean up and fix README.md
kimoonkim Dec 19, 2017
0f8fad9
Fix README.md
kimoonkim Dec 19, 2017
7bc4aa2
Remove unnecessary close
kimoonkim Dec 19, 2017
9ec071a
Clean up
kimoonkim Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up pom.xml
  • Loading branch information
@kimoonkim
kimoonkim committed Dec 15, 2017
commit 7c8612ce82a3401f8db12843930e8f0f328108e8
99 changes: 0 additions & 99 deletions integration-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<version>0.1-SNAPSHOT</version>
<properties>
<commons-lang3.version>3.5</commons-lang3.version>
<fasterxml.jackson.version>2.6.5</fasterxml.jackson.version>
<jsr305.version>1.3.9</jsr305.version>
<kubernetes.client.version>3.0.0</kubernetes.client.version>
<log4j.version>1.2.17</log4j.version>
Expand All @@ -40,26 +39,6 @@
<artifactId>commons-logging</artifactId>
<version>1.1.1</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
Expand All @@ -77,55 +56,11 @@
<artifactId>docker-client</artifactId>
<version>5.0.2</version>
Copy link
Contributor

@mccheah mccheah Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should have a universal standard of having these versions defined at the top. I'm not strongly opinionated here, but it's something to consider.

Copy link
Contributor

@mccheah mccheah Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just strange that some versions are hardcoded here while others are in constants.

Copy link
Member Author

@kimoonkim kimoonkim Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I can put all of them in properties.

<scope>test</scope>
<!--
See https://github.com/spotify/docker-client/pull/272#issuecomment-155249101
for an explanation of why these exclusions are (necessarily) a mess.
-->
<exclusions>
<exclusion>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
<artifactId>jackson-jaxrs-json-provider</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
<exclusion>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-client</artifactId>
</exclusion>
<exclusion>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-common</artifactId>
</exclusion>
<exclusion>
<groupId>javax.ws.rs</groupId>
<artifactId>jsr311-api</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-client</artifactId>
<version>${kubernetes.client.version}</version>
<exclusions>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>log4j</groupId>
Expand Down Expand Up @@ -185,40 +120,6 @@
</resources>
</configuration>
</execution>
<execution>
<id>copy-integration-python</id>
<phase>pre-integration-test</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/docker/python</outputDirectory>
<resources>
<resource>
<directory>${project.parent.basedir}/python</directory>
<excludes>
<exclude>${project.parent.basedir}/python/.egg</exclude>
<exclude>${project.parent.basedir}/python/dist</exclude>
</excludes>
</resource>
</resources>
</configuration>
</execution>
<execution>
<id>copy-integration-r</id>
<phase>pre-integration-test</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/docker/R</outputDirectory>
<resources>
<resource>
<directory>${project.parent.basedir}/R</directory>
</resource>
</resources>
</configuration>
</execution>
<execution>
<id>copy-integration-data</id>
<phase>pre-integration-test</phase>
Expand Down