Review feedback

helm-tests/tests/helm_tests/airflow_core/test_triggerer.py

@@ -26,8 +26,8 @@ class TestTriggerer:
     """Tests triggerer."""
 
     @pytest.mark.parametrize("airflow_version", ["2.11.0", "3.0.0"])
-    def test_only_exists_on_new_airflow_versions(self, airflow_version):
-        """Trigger was only added from Airflow 2.2 onwards."""
+    def test_only_exists(self, airflow_version):
+        """Check that Triggerer was added."""
         docs = render_chart(
             values={"airflowVersion": airflow_version},
             show_only=["templates/triggerer/triggerer-deployment.yaml"],
@@ -482,19 +482,16 @@ def test_livenessprobe_values_are_configurable(self):
         ]
 
     @pytest.mark.parametrize(
-        ("airflow_version", "probe_command"),
-        [
-            ("2.11.0", "airflow jobs check --job-type TriggererJob --local"),
-            ("3.0.0", "airflow jobs check --job-type TriggererJob --local"),
-        ],
+        "airflow_version",
+        ["2.11.0", "3.0.0"],
     )
-    def test_livenessprobe_command_depends_on_airflow_version(self, airflow_version, probe_command):
+    def test_livenessprobe_command_depends_on_airflow_version(self, airflow_version):
         docs = render_chart(
             values={"airflowVersion": f"{airflow_version}"},
             show_only=["templates/triggerer/triggerer-deployment.yaml"],
         )
         assert (
-            probe_command
+            "airflow jobs check --job-type TriggererJob --local"
             in jmespath.search("spec.template.spec.containers[0].livenessProbe.exec.command", docs[0])[-1]
         )
 

helm-tests/tests/helm_tests/security/test_rbac.py

@@ -36,13 +36,15 @@
     ("Service", "test-rbac-flower"),
     ("Service", "test-rbac-pgbouncer"),
     ("Service", "test-rbac-redis"),
+    ("Service", "test-rbac-triggerer"),
     ("Service", "test-rbac-worker"),
     ("Deployment", "test-rbac-scheduler"),
     ("Deployment", "test-rbac-statsd"),
     ("Deployment", "test-rbac-flower"),
     ("Deployment", "test-rbac-pgbouncer"),
     ("StatefulSet", "test-rbac-postgresql"),
     ("StatefulSet", "test-rbac-redis"),
+    ("StatefulSet", "test-rbac-triggerer"),
     ("StatefulSet", "test-rbac-worker"),
     ("Secret", "test-rbac-broker-url"),
     ("Secret", "test-rbac-fernet-key"),
@@ -112,8 +114,6 @@ def _is_airflow_3_or_above(self, version):
 
     def _get_object_tuples(self, version, sa: bool = True):
         tuples = copy(DEPLOYMENT_NO_RBAC_NO_SA_KIND_NAME_TUPLES)
-        tuples.append(("Service", "test-rbac-triggerer"))
-        tuples.append(("StatefulSet", "test-rbac-triggerer"))
         if self._is_airflow_3_or_above(version):
             tuples.extend(
                 (