Skip to content

Refactor Git-Sync livenessProbe & deprecate readinessProbe & add startupProbe #62334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 9 commits into from
Mar 9, 2026
Merged

Refactor Git-Sync livenessProbe & deprecate readinessProbe & add startupProbe #62334

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9aadac6
Deploy Git-Sync liveness service
Miretpl Feb 27, 2026
811df17
Add recommendedProbeSetting flag
Miretpl Mar 2, 2026
3810498
Refactor git-sync probes tests
Miretpl Mar 2, 2026
b821840
Remove usage of GitSync readinessProbe
Miretpl Feb 27, 2026
5fc80dc
Refactor git-sync liveness probe
Miretpl Mar 8, 2026
56e3aac
Add git-sync startup probe
Miretpl Mar 8, 2026
8d4580d
Misc
Miretpl Mar 8, 2026
c32e398
Fix spellcheck
Miretpl Mar 8, 2026
295f8b2
Merge branch 'main' into add-gitsync-startup-probe
Miretpl Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix spellcheck
  • Loading branch information
@Miretpl
Miretpl committed Mar 8, 2026
commit c32e398d598a72a2c1061d20833a9d8f29edadb5
2 changes: 2 additions & 0 deletions chart/newsfragments/62334.significant.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
As Git-Sync is not service-type object, the readiness probe will be removed. To enable feature behaviour set ``dags.gitSync.recommendedProbeSetting`` to ``true``. Section itself will be removed in future release as to not break setups during upgrades.

As Git-Sync has dedicated liveness service, the liveness probe behaviour will be changed. To enable feature behaviour set ``dags.gitSync.recommendedProbeSetting`` to ``true``.

Please update your configuration accordingly.
2 changes: 1 addition & 1 deletion chart/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10655,7 +10655,7 @@
"default": 1234
},
"recommendedProbeSetting": {
"description": "Setting this to true, will remove readinessProbe usage and configure livenessProbe to use a dedicated Git-Sync liveness service.",
"description": "Setting this to true, will remove readiness probe usage and configure liveness probe to use a dedicated Git-Sync liveness service.",
"type": "boolean",
"default": false
},
Expand Down
14 changes: 5 additions & 9 deletions helm-tests/tests/helm_tests/other/test_git_sync_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def test_liveness_probe_configuration(self):
)

assert livenessProbe == jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].livenessProbe", docs[0]
"spec.template.spec.containers[?name=='git-sync'] | [0].livenessProbe", docs[0]
)

def test_readiness_probe_configuration(self):
Expand Down Expand Up @@ -479,15 +479,13 @@ def test_readiness_probe_configuration(self):

assert (
jmespath.search(
"spec.template.spec.initContainers[?name == 'git-sync-init'] | [0].readinessProbe", docs[0]
"spec.template.spec.initContainers[?name=='git-sync-init'] | [0].readinessProbe", docs[0]
)
is None
)

assert (
jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].readinessProbe", docs[0]
)
jmespath.search("spec.template.spec.containers[?name=='git-sync'] | [0].readinessProbe", docs[0])
== readinessProbe
)

Expand Down Expand Up @@ -517,15 +515,13 @@ def test_readiness_probe_configuration_recommended(self):

assert (
jmespath.search(
"spec.template.spec.initContainers[?name == 'git-sync-init'] | [0].readinessProbe", docs[0]
"spec.template.spec.initContainers[?name=='git-sync-init'] | [0].readinessProbe", docs[0]
)
is None
)

assert (
jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].readinessProbe", docs[0]
)
jmespath.search("spec.template.spec.containers[?name=='git-sync'] | [0].readinessProbe", docs[0])
is None
)

Expand Down
12 changes: 5 additions & 7 deletions helm-tests/tests/helm_tests/other/test_git_sync_triggerer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def test_liveness_probe_configuration(self):
)

assert livenessProbe == jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].livenessProbe", docs[0]
"spec.template.spec.containers[?name=='git-sync'] | [0].livenessProbe", docs[0]
)

def test_readiness_probe_configuration(self):
Expand All @@ -127,13 +127,13 @@ def test_readiness_probe_configuration(self):

assert (
jmespath.search(
"spec.template.spec.initContainers[?name == 'git-sync-init'] | [0].readinessProbe", docs[0]
"spec.template.spec.initContainers[?name=='git-sync-init'] | [0].readinessProbe", docs[0]
)
is None
)

assert readinessProbe == jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].readinessProbe", docs[0]
"spec.template.spec.containers[?name=='git-sync'] | [0].readinessProbe", docs[0]
)

def test_readiness_probe_configuration_recommended(self):
Expand Down Expand Up @@ -162,15 +162,13 @@ def test_readiness_probe_configuration_recommended(self):

assert (
jmespath.search(
"spec.template.spec.initContainers[?name == 'git-sync-init'] | [0].readinessProbe", docs[0]
"spec.template.spec.initContainers[?name=='git-sync-init'] | [0].readinessProbe", docs[0]
)
is None
)

assert (
jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].readinessProbe", docs[0]
)
jmespath.search("spec.template.spec.containers[?name=='git-sync'] | [0].readinessProbe", docs[0])
is None
)

Expand Down
12 changes: 5 additions & 7 deletions helm-tests/tests/helm_tests/other/test_git_sync_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def test_liveness_probe_configuration(self):
)

assert livenessProbe == jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].livenessProbe", docs[0]
"spec.template.spec.containers[?name=='git-sync'] | [0].livenessProbe", docs[0]
)

def test_readiness_probe_configuration(self):
Expand All @@ -252,13 +252,13 @@ def test_readiness_probe_configuration(self):

assert (
jmespath.search(
"spec.template.spec.initContainers[?name == 'git-sync-init'] | [0].readinessProbe", docs[0]
"spec.template.spec.initContainers[?name=='git-sync-init'] | [0].readinessProbe", docs[0]
)
is None
)

assert readinessProbe == jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].readinessProbe", docs[0]
"spec.template.spec.containers[?name=='git-sync'] | [0].readinessProbe", docs[0]
)

def test_readiness_probe_configuration_recommended(self):
Expand Down Expand Up @@ -287,15 +287,13 @@ def test_readiness_probe_configuration_recommended(self):

assert (
jmespath.search(
"spec.template.spec.initContainers[?name == 'git-sync-init'] | [0].readinessProbe", docs[0]
"spec.template.spec.initContainers[?name=='git-sync-init'] | [0].readinessProbe", docs[0]
)
is None
)

assert (
jmespath.search(
"spec.template.spec.containers[?name == 'git-sync'] | [0].readinessProbe", docs[0]
)
jmespath.search("spec.template.spec.containers[?name=='git-sync'] | [0].readinessProbe", docs[0])
is None
)

Expand Down
Loading