Skip to content

Add --action-on-existing-key to pools import and connections import#62702

Merged
bugraoz93 merged 1 commit into
apache:mainfrom
Leondon9:fix/62695-import-action-on-existing-key
Mar 9, 2026
Merged

Add --action-on-existing-key to pools import and connections import#62702
bugraoz93 merged 1 commit into
apache:mainfrom
Leondon9:fix/62695-import-action-on-existing-key

Conversation

@Leondon9
Copy link
Copy Markdown
Contributor

@Leondon9 Leondon9 commented Mar 2, 2026

variables import supports --action-on-existing-key, but pools import and connections import hardcode action_on_existence=FAIL.

This adds the same --action-on-existing-key (overwrite/fail/skip) option to both commands.

  • Default is fail (no behavior change for existing users)
  • Follows the same pattern as ARG_VARIABLE_ACTION_ON_EXISTING_KEY

closes: #62695


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (claude-opus-4-6)

Generated-by: Claude Code (claude-opus-4-6) following the guidelines

Copy link
Copy Markdown
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think there are small improvements we can make :) Could you please check them out?

Comment thread airflow-ctl/src/airflowctl/ctl/cli_config.py
Comment thread airflow-ctl/src/airflowctl/ctl/commands/connection_command.py Outdated
Comment thread airflow-ctl/src/airflowctl/ctl/commands/connection_command.py Outdated
…ort`

closes: apache#62695

Co-Authored-By: claude-flow <ruv@ruv.net>
@Leondon9 Leondon9 force-pushed the fix/62695-import-action-on-existing-key branch from e9522b8 to f1f4773 Compare March 4, 2026 07:05
@Leondon9
Copy link
Copy Markdown
Contributor Author

Leondon9 commented Mar 7, 2026

@bugraoz93 Could you review this PR again?

@bugraoz93 bugraoz93 merged commit 139cd98 into apache:main Mar 9, 2026
82 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Mar 10, 2026
thejoeejoee pushed a commit to thejoeejoee/airflow that referenced this pull request Mar 10, 2026
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
Pyasma pushed a commit to Pyasma/airflow that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

airflow-ctl: pools import and connections import missing --action-on-existing-key option

2 participants