Skip to content

Conversation

sy-records
Copy link
Member

@LinkinStars LinkinStars self-requested a review September 22, 2025 01:50
@LinkinStars LinkinStars self-assigned this Sep 22, 2025
@LinkinStars
Copy link
Member

After testing, I found two issues.

  1. When reviewing a comment, clicking "Reject" is invalid and the comment still exists. We need to add relevant processing work for comments in this method.
    func (cs *ReviewService) updateObjectStatus(ctx context.Context, review *entity.Review, isApprove bool) (err error) {
  2. We might need to add a status(CommentStatusPending) to the comment, similar to the question. Don't display the comment when it is in this state.
    QuestionStatusPending = 11

@sy-records sy-records marked this pull request as draft September 22, 2025 10:38
@sy-records sy-records marked this pull request as ready for review September 23, 2025 03:04
Copy link
Member

@LinkinStars LinkinStars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@LinkinStars LinkinStars merged commit bec3e35 into apache:dev Sep 23, 2025
@LinkinStars LinkinStars added this to the v1.7.0 milestone Sep 23, 2025
@sy-records sy-records deleted the review/comment branch September 23, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants