feat(csharp/src/Drivers/Apache): Implement Standard SSL mode for Impala #2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhiremmadi
changed the title
CurtHagenlocher
requested changes
May 1, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! Please fix the one method name to be consistent with C# naming conventions.
| return httpClientHandler; | ||
| } | ||
|
|
||
| static internal TlsProperties GetStandardTlsOptions(IReadOnlyDictionary<string, string> properties) |
Contributor
There was a problem hiding this comment.
There's no way to share this setup logic with the HTTP code path? They are practically identical.
In hindsight, it would have been better to have a TLS property set that was independent of HTTP vs TCP transport.
Contributor
Author
There was a problem hiding this comment.
Changing connection properties is not recommended, hence added new properties for TCP transport
CurtHagenlocher
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.