ci(rust): verify MSRV of each package #2996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Jun 18, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Thanks! Just a question on how it's installed
.github/workflows/rust.yml
Outdated
| if: matrix.os == 'ubuntu-latest' | ||
| working-directory: rust | ||
| run: | | ||
| curl -L "https://github.com/foresterre/cargo-msrv/releases/download/v0.18.4/cargo-msrv-x86_64-unknown-linux-gnu-v0.18.4.tgz" | |
Member
There was a problem hiding this comment.
(1) Could we perhaps validate the SHA so that upstream can't change it unexpectedly?
(2) Does it make sense to use cargo install instead (with a specific commit), or a specific version of their Docker image? (With Docker, we could even set this up so that it's run by docker-compose)
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment. I too wondered if we needed to check hash.
(The protoc installed within this workflow does not seem to be checked, so I did not too)
How about 38e1223?
- I considered a source install (similar to arrow-rs) first, but decided that a binary download would be better since it takes longer to build without a cache.
- I had not noticed this about Docker images, but it seemed difficult to choose which images to use because images are tagged and pushed at a higher frequency than releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2739
Verify on CI that the MSRV specification for each package is correct using the command based on the cargo-msrv (copied from the arrow-rs repo).