fix(go/adbc): adding back compatibility for function FlightSQLDriverInit #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howareyouman
changed the title
howareyouman
changed the title
cultcargo
approved these changes
Jun 27, 2025
zeroshade
approved these changes
Jun 27, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
This probably got lost when these were re-generated at some point. Should we put this function in a non-generated file so that we don't accidentally lose it again?
Contributor
Author
Now we should put these 2 functions then - FlightSQLDriverInit, FlightSqlDriverInit. |
Contributor
Author
|
@zeroshade I will do it in the next PR |
Contributor
Author
|
@zeroshade could you please merge the PR? I cannot do it myself. |
Contributor
Author
|
@zeroshade The pr with migration of these 2 functions to go driver code - here |
zeroshade
pushed a commit
that referenced
this pull request
Jul 7, 2025
…3079) Moving FlightSQLDriverInit function to a separate go file. Resolving the request from the recent PR - [link](#3056 (review))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returning back function FlightSQLDriverInit
Fixes 3055.