feat(csharp/src/Drivers/Databricks): Remove redundant closeoperation #3093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadewang-db
reviewed
Jul 3, 2025
| private async Task<QueryResult> GetQueryResult(TSparkDirectResults? directResults, CancellationToken cancellationToken) | ||
| { | ||
| // Set _directResults so that dispose logic can check if operation was already closed | ||
| _directResults = directResults; |
Contributor
There was a problem hiding this comment.
looks like we don't have test here, can we add one?
toddmeng-db
force-pushed
the
toddmeng-db/closeop-error
branch
from
d32db4a to
b57282b
Compare
CurtHagenlocher
approved these changes
Jul 3, 2025
CurtHagenlocher
pushed a commit
that referenced
this pull request
Jul 11, 2025
…for GetColumnsAsync (#3132) [A previous PR](#3093) fixed redundant CloseOperations that were throwing errors and causing failure for dbr 11.3 and below. GetColumnsAsync uses a seperate response handling path, which does not call GetQueryResults (where the previous fix was implemented), so this operation still fails. This PR adds a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver was breaking with DBR 11.3.
This PR introduced logic which throws errors via HandleThriftResponse. Previously, we had been silently ignoring these CloseOperation failures; these errors occurred because the operations can be closed when returning via DirectResults, and we weren't properly checking for DirectResults.CloseOperation status for Metadata queries. With this change, we avoid making redundant CloseOperation requests upon dispose.
Testing
Added a test that only passes with the changes in this PR in DBR 11.3