fix(csharp/src/Drivers/Databricks): Reader Refactors #3254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddmeng-db
changed the title
toddmeng-db
force-pushed
the
toddmeng-db/reader-unit-testing
branch
from
29e90de to
85a8a8c
Compare
toddmeng-db
force-pushed
the
toddmeng-db/reader-unit-testing
branch
from
85a8a8c to
6af32c9
Compare
eric-wang-1990
approved these changes
Aug 11, 2025
Contributor
eric-wang-1990
left a comment
eric-wang-1990
left a comment
There was a problem hiding this comment.
LGTM overall, let's wait for Curt's approval as well
Contributor
|
@toddmeng-db can you publish the PR if it's ready? |
CurtHagenlocher
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactors to make it easier to unit test. (follow-up pr: #3255)