Skip to content

fix(go/adbc/driver/snowflake): return arrow numeric type correctly when use_high_precision is false #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 4 commits into from
Oct 7, 2025
Merged

fix(go/adbc/driver/snowflake): return arrow numeric type correctly when use_high_precision is false #3295

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7687b15
Fix for handling NUMBER scale correctly when use_high_precision is fa…
praveentandra Aug 17, 2025
d8ee74d
Add test to verify types during ExecuteSchema when use_high_precision…
praveentandra Aug 27, 2025
1a550c3
fix: Apply go fmt to driver_test.go
praveentandra Aug 27, 2025
e9a247d
fix: Remove trailing whitespace in driver_test.go
praveentandra Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion go/adbc/driver/snowflake/record_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,12 @@ func rowTypesToArrowSchema(_ context.Context, ld gosnowflake.ArrowStreamLoader,
Scale: int32(srcMeta.Scale),
}
} else {
fields[i].Type = arrow.PrimitiveTypes.Int64
// Check scale to determine if this is an integer or decimal
if srcMeta.Scale == 0 {
fields[i].Type = arrow.PrimitiveTypes.Int64
} else {
fields[i].Type = arrow.PrimitiveTypes.Float64
}
}
case "real":
fields[i].Type = arrow.PrimitiveTypes.Float64
Expand Down
Loading