-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
enhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crateChanges to the parquet crate
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We added the ParquetPushDecoder in #7997
One of the rationales is to avoid duplicating the control logic between the Async Reader and the Sync Reader.
However, it actually (temporarily) makes the problem worse by adding a 3rd copy of the control logic ala the xkcd standards effect
Describe the solution you'd like
- Refactor the
ParquetRecordBatchStreamto useParquetPushDecoder
Describe alternatives you've considered
Additional context
- Rewrite
ParquetRecordBatchReader(sync api) in terms of the PushDecoder #8678 covers the sync API
Metadata
Metadata
Assignees
Labels
enhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crateChanges to the parquet crate