Skip to content

fix: pin ahash to 0.8.0 #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattbonnell wants to merge 1 commit into from
Closed

fix: pin ahash to 0.8.0 #3048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: pin ahash to 0.8.0 
0.8.1 has a bug tkaitchuck/aHash#143
  • Loading branch information
@mattbonnell
mattbonnell authored Nov 8, 2022
commit ef8aebc01d54773ce99823d4c4d54751e603ccb7
4 changes: 2 additions & 2 deletions arrow/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ path = "src/lib.rs"
bench = false

[target.'cfg(target_arch = "wasm32")'.dependencies]
ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] }
ahash = { version = "0.8.0", default-features = false, features = ["compile-time-rng"] }
Copy link
Contributor

@tustvold tustvold Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ahash = { version = "0.8.0", default-features = false, features = ["compile-time-rng"] }
ahash = { version = "=0.8.0", default-features = false, features = ["compile-time-rng"] }

FYI you will need an exact version pin, cargo applies semver compatibility by default


[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
ahash = { version = "0.8", default-features = false, features = ["runtime-rng"] }
ahash = { version = "0.8.0", default-features = false, features = ["runtime-rng"] }

[dependencies]
arrow-buffer = { version = "26.0.0", path = "../arrow-buffer" }
Expand Down