Conversation
ccb4cf3 to
081fa1f
Compare
|
I'm 👍 👍 👍 for this, but I don't have permissions on the repo. I think installing this will require @alamb. |
|
I triggered the workflow on this PR but I think codspeed won't run until we merge it One way to test is to make some PRs against your own fork of |
I double checked the permission that needed by CodSpeed. It only needs read permission which should be ok for the ASF INFRA team. |
333a86c to
abc71d2
Compare
|
The
If I understand correctly, the way to allow those actions is to first merge this PR? |
I think this may be due to ASF security policy: https://infra.apache.org/github-actions-policy.html Looks like maybe we have to pin the action to a specific SHA? |
abc71d2 to
c804a1a
Compare
I pinned the two actions to specific SHAs, the workflow still fails. |
Hi, it doesn't work in this way. We need the INFRA team to approve those actions via jira tickets. Here is an example: https://issues.apache.org/jira/projects/INFRA/issues/INFRA-25997 I'm willing to help do this if you want. |
|
Hi, we have submited a ticket to enable codspeed: https://issues.apache.org/jira/browse/INFRA-26030. Maybe @alamb want to comment your same request too? |
|
Hi, @adriencaccia the ASF INFRA team has question about the github app's permission request:
Do you have any response to this? |
Hey @Xuanwo, we only access the email addresses of the members of a GitHub organization to ensure that a logged user on CodSpeed is indeed a member of this organization. |
|
Hey @Xuanwo, is there anything I can do to help merge this? |
Hi, we are waiting for the ASF INFRA team to review this request. |

Which issue does this PR close?
Closes #6149
@samuelcolvin, I let you take it from here if you want :)
In order for it to work, https://codspeed.io/ needs to be installed on the organization and the repo.
What changes are included in this PR?
A new workflow
benchmark.ymlthat runs on every PR and the defaultmasterbranch.The
criteriondependency is changed tocodspeed-criterion-compat.The
eq scalar StringViewArraybench is commented out, because it fails on the runner.Are there any user-facing changes?
No.