-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ParquetMetaDataReader
#6431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2cc99ed
add ParquetMetaDataReader
etseidl 8d29173
Merge branch 'apache:master' into pq_metadata_reader
etseidl d3136ec
clippy
etseidl 41a92b1
Merge branch 'pq_metadata_reader' of github.com:etseidl/arrow-rs into…
etseidl 97f5d69
Apply suggestions from code review
etseidl 33bfd88
formatting
etseidl 503ec85
Merge remote-tracking branch 'origin/master' into pq_metadata_reader
etseidl 5baf071
add ParquetMetaDataReader to module documentation
etseidl a4943a1
document erros returned from `try_parse_sized`
etseidl 3bc8232
oops
etseidl 43d01d1
rename methods per review suggestion
etseidl 7d95bbb
Merge remote-tracking branch 'origin/master' into pq_metadata_reader
etseidl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
document erros returned from
try_parse_sized
- Loading branch information
commit a4943a1dfcd076b912d6113e6be25d666320d1c0
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would help here to document what errors are returned (specifically how "needs more buffer" is communicated)
I see it is partly covered in the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added