Skip to content

Detect missing page indexes while reading Parquet metadata #6507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Oct 3, 2024
Merged

Detect missing page indexes while reading Parquet metadata #6507

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0099e34
detect missing page indexes on read
etseidl Oct 3, 2024
5719312
lint
etseidl Oct 3, 2024
792d13b
fix overlap test
etseidl Oct 3, 2024
ebfb67e
add some clarifying comments per review suggestion
etseidl Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add some clarifying comments per review suggestion
  • Loading branch information
@etseidl
etseidl committed Oct 3, 2024
commit ebfb67e44a14cac220c325c792854d4e950c7b2d
6 changes: 4 additions & 2 deletions parquet/src/file/metadata/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ pub struct ParquetMetaDataReader {
column_index: bool,
offset_index: bool,
prefetch_hint: Option<usize>,
// size of the serialized thrift metadata plus the 8 byte footer
// Size of the serialized thrift metadata plus the 8 byte footer. Only set if
// `self.parse_metadata` is called.
metadata_size: Option<usize>,
}

Expand Down Expand Up @@ -470,7 +471,8 @@ impl ParquetMetaDataReader {
range
}

// one-shot parse of footer
// One-shot parse of footer.
// Side effect: this will set `self.metadata_size`
fn parse_metadata<R: ChunkReader>(&mut self, chunk_reader: &R) -> Result<ParquetMetaData> {
// check file is large enough to hold footer
let file_size = chunk_reader.len();
Expand Down