fix: enable TLS roots for flight CLI client #6640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise you get:
```text
Error: setup client
Caused by:
0: connect to endpoint
1: transport error
2: invalid peer certificate: UnknownIssuer
3: invalid peer certificate: UnknownIssuer
```
Also see hyperium/tonic#1904 .
github-actions
bot
added
arrow
tustvold
approved these changes
Oct 29, 2024
Contributor
|
Ideally we'd have a test of this, but I don't feel strongly and it is probably difficult to setup |
Contributor
Author
I thought about that, but that would require that we have a server that has a certificate that is accepted by the Mozilla CA bundle, so without additional infrastructure, I don't think that's feasible. Or we do something "stupid" like point the client to |
Contributor
|
That sounds like it could very well end up being flaky, I think let's leave it for now and we can always revisit |
alamb
added a commit
to influxdata/arrow-rs
that referenced
this pull request
Dec 2, 2024
This reverts commit 2983dc1.
wiedld
pushed a commit
to influxdata/arrow-rs
that referenced
this pull request
Jan 31, 2025
This reverts commit 2983dc1.
alamb
added a commit
to influxdata/arrow-rs
that referenced
this pull request
Feb 1, 2025
This reverts commit 2983dc1.
thinkharderdev
pushed a commit
to coralogix/arrow-rs
that referenced
this pull request
May 1, 2025
This reverts commit 2983dc1.
thinkharderdev
added a commit
to coralogix/arrow-rs
that referenced
this pull request
May 5, 2025
This reverts commit 244d8bd.
thinkharderdev
added a commit
to coralogix/arrow-rs
that referenced
this pull request
May 7, 2025
* Revert "bump `tonic` to 0.12 and `prost` to 0.13 for `arrow-flight` (apache#6041)" This reverts commit 741bbf6. # Conflicts: # arrow-flight/Cargo.toml # arrow-flight/gen/Cargo.toml # arrow-flight/src/arrow.flight.protocol.rs # arrow-integration-testing/Cargo.toml * Revert "fix: enable TLS roots for flight CLI client (apache#6640)" This reverts commit 2983dc1. * Add rowid to parquet reader * make sure stream has correct schema * handle specifying row groups * remove println * add prefetching for row filter fetch * remove println * fix bug in prefetch * fix properly * remove println * chrono dep * use row_id intead of rowid * Reapply "fix: enable TLS roots for flight CLI client (apache#6640)" This reverts commit 244d8bd. * Reapply "bump `tonic` to 0.12 and `prost` to 0.13 for `arrow-flight` (apache#6041)" This reverts commit 7750691. --------- Co-authored-by: Andrew Lamb <[email protected]>
wiedld
pushed a commit
to influxdata/arrow-rs
that referenced
this pull request
May 21, 2025
This reverts commit 2983dc1.
wiedld
pushed a commit
to influxdata/arrow-rs
that referenced
this pull request
May 22, 2025
This reverts commit 2983dc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
-
Rationale for this change
Otherwise you get:
Also see hyperium/tonic#1904 .
What changes are included in this PR?
Just call the method that registers the roots that we include via feature flags anyways.
Are there any user-facing changes?
TLS works again.