-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Experimental parquet decoder with first-class selection pushdown support #6921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 23 commits
cc6dd14
5837fc7
fec6313
948db87
8c50d90
f5422ce
dfdc1b6
3c526f8
53f5fad
56980de
4dd1b6b
f8f983e
882aaf1
c8bdbcf
cdb1d85
69720e5
a9550ab
be1435f
e4d9eb7
21e015b
bbc3595
547fb46
05c8c8f
314fda1
c895dd2
3cf0a98
7b72f9d
5bdf51a
a77e1e7
90a55d5
9ffa81c
7c10b4a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -463,6 +463,8 @@ impl ByteViewArrayDecoderDictionary { | |
| } | ||
| } | ||
|
|
||
| output.views.reserve(len); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I broke this change out into a new PR |
||
|
|
||
| // Calculate the offset of the dictionary buffers in the output buffers | ||
| // For example if the 2nd buffer in the dictionary is the 5th buffer in the output buffers, | ||
| // then the base_buffer_idx is 5 - 2 = 3 | ||
|
|
@@ -683,7 +685,7 @@ impl ByteViewArrayDecoderDelta { | |
|
|
||
| /// Check that `val` is a valid UTF-8 sequence | ||
| pub fn check_valid_utf8(val: &[u8]) -> Result<()> { | ||
| match std::str::from_utf8(val) { | ||
| match simdutf8::basic::from_utf8(val) { | ||
|
||
| Ok(_) => Ok(()), | ||
| Err(e) => Err(general_err!("encountered non UTF-8 data: {}", e)), | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.