Skip to content

Remove AsyncFileReader::get_metadata_with_options, add options to AsyncFileReader::get_metadata #7342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 11 commits into from
Apr 1, 2025
Merged

Remove AsyncFileReader::get_metadata_with_options, add options to AsyncFileReader::get_metadata #7342

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7dac485
Remove default implementation for get_metadata_with_options and expla…
corwinjoy Mar 27, 2025
a86c499
Improve comment about missing implementation.
corwinjoy Mar 27, 2025
a784060
Update get_metadata method to take an optional ArrowReaderOptions.
corwinjoy Mar 28, 2025
62d6a84
Fix handling of unencrypted footer.
corwinjoy Mar 28, 2025
32944d5
Checking git tests, it seems I missed a couple dead calls. Fixed.
corwinjoy Mar 29, 2025
d09313f
Fix path with no encryption enabled.
corwinjoy Mar 29, 2025
fbf2519
Make have_decryptor a bit more bullet-proof.
corwinjoy Mar 29, 2025
6615e27
Update expected error message in test_decrypting_without_decryption_p…
corwinjoy Mar 29, 2025
2158f31
Tidy up get_metadata
adamreeve Mar 31, 2025
a7ecf91
Merge remote-tracking branch 'origin/main' into explicit_get_metadata…
corwinjoy Apr 1, 2025
d1a5843
Fix merge conflicts.
corwinjoy Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions parquet/src/arrow/async_reader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,12 @@ pub trait AsyncFileReader: Send {
/// allowing fine-grained control over how metadata is sourced, in particular allowing
/// for caching, pre-fetching, catalog metadata, decrypting, etc...
///
/// By default calls `get_metadata()`
/// No default because options under encryption are significant.
/// We want the end-user to be explicit about what they want here.
fn get_metadata_with_options<'a>(
&'a mut self,
options: &'a ArrowReaderOptions,
) -> BoxFuture<'a, Result<Arc<ParquetMetaData>>> {
let _ = options;
self.get_metadata()
}
) -> BoxFuture<'a, Result<Arc<ParquetMetaData>>>;
}

/// This allows Box<dyn AsyncFileReader + '_> to be used as an AsyncFileReader,
Expand Down
Loading