Skip to content

[Variant] Add variant_get and Shredded VariantArray #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 18 commits into from
Aug 7, 2025
Merged

[Variant] Add variant_get and Shredded VariantArray #8021

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3ba9fe0
[Variant] Strawman / infrastructure for variant_get of shredded values
alamb Jul 18, 2025
f458ec5
Apply suggestions from code review
alamb Aug 5, 2025
52cf52b
Merge remote-tracking branch 'apache/main' into alamb/variant_shreddi…
alamb Aug 5, 2025
6b66650
remove completed todo comment
alamb Aug 5, 2025
924155c
Move validation logic to `ShreddingState::try_new`
alamb Aug 5, 2025
5cb1068
Apply suggestions from code review
alamb Aug 6, 2025
9c22f85
cleanup
alamb Aug 6, 2025
eee199e
Avoid panics in production code
alamb Aug 6, 2025
264356b
Merge remote-tracking branch 'apache/main' into alamb/variant_shreddi…
alamb Aug 6, 2025
336a0a3
comments
alamb Aug 6, 2025
016cee1
Merge remote-tracking branch 'apache/main' into alamb/variant_shreddi…
alamb Aug 7, 2025
3e8820b
Fix up merge
alamb Aug 7, 2025
55a7ae6
Update parquet-variant-compute/src/variant_array.rs
alamb Aug 7, 2025
85e7194
Merge branch 'alamb/variant_shredding_strawman' of github.com:alamb/a…
alamb Aug 7, 2025
6e38490
fix compilation
alamb Aug 7, 2025
0ccd0f8
update docs
alamb Aug 7, 2025
f8b2df4
Rename ShreddingState to conform better to spec
alamb Aug 7, 2025
2355247
Update name in output builder
alamb Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Samyak Sarnayak <[email protected]>
  • Loading branch information
@alamb @Samyak2
alamb and Samyak2 authored Aug 5, 2025
commit f458ec555f2f1750cdcb4069d0c8b2e7d54d15bc
2 changes: 1 addition & 1 deletion parquet-variant-compute/src/variant_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ impl VariantArray {
/// Dictionary-Encoded, preferably (but not required) with an index type of
/// int8.
///
/// Currently, only [`BinaryViewArray`] are supported.
/// Currently, only [`BinaryViewArray`] are supported.
///
/// [`BinaryViewArray`]: arrow::array::BinaryViewArray
pub fn try_new(inner: ArrayRef) -> Result<Self, ArrowError> {
Expand Down
Loading