Skip to content

[Variant] Minor: use From impl to make conversion infallable #8068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Aug 6, 2025
Merged

[Variant] Minor: use From impl to make conversion infallable #8068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions parquet-variant/src/variant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ impl From<u8> for Variant<'_, '_> {
if let Ok(value) = i8::try_from(value) {
Variant::Int8(value)
} else {
Variant::Int16(value as i16)
Variant::Int16(i16::from(value))
}
}
}
Expand All @@ -1166,7 +1166,7 @@ impl From<u16> for Variant<'_, '_> {
if let Ok(value) = i16::try_from(value) {
Variant::Int16(value)
} else {
Variant::Int32(value as i32)
Variant::Int32(i32::from(value))
}
}
}
Expand All @@ -1176,7 +1176,7 @@ impl From<u32> for Variant<'_, '_> {
if let Ok(value) = i32::try_from(value) {
Variant::Int32(value)
} else {
Variant::Int64(value as i64)
Variant::Int64(i64::from(value))
}
}
}
Expand All @@ -1188,7 +1188,7 @@ impl From<u64> for Variant<'_, '_> {
Variant::Int64(value)
} else {
// u64 max is 18446744073709551615, which fits in i128
Variant::Decimal16(VariantDecimal16::try_new(value as i128, 0).unwrap())
Variant::Decimal16(VariantDecimal16::try_new(i128::from(value), 0).unwrap())
}
}
}
Expand Down
Loading