Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
alamb committed Aug 20, 2025
commit be330afbfb6f0849b64dad4dca67d7a9741a6c88
4 changes: 2 additions & 2 deletions parquet/src/util/push_buffers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ use std::ops::Range;
///
/// Thus, the implementation defers to the caller to coalesce subsequent requests
/// if desired.
# [derive(Debug, Clone)]
#[derive(Debug, Clone)]
pub(crate) struct PushBuffers {
/// the virtual "offset" of this buffers (added to any request)
offset: u64,
Expand Down Expand Up @@ -137,7 +137,7 @@ impl Length for PushBuffers {
}
}

/// less efficinet implementation of Read for Buffers
/// less efficient implementation of Read for Buffers
impl std::io::Read for PushBuffers {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This std::io::Read impl is needed so the current thrift decoder can read bytes

I suspect when @etseidl is done with his custom thrift decoder we can remove this impl

fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
// Find the range that contains the start offset
Expand Down
Loading