Migrate arrow-schema to Rust 2024
#8489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Sep 29, 2025
| return; | ||
| } | ||
| let schema = &mut *schema; | ||
| let schema = unsafe { &mut *schema }; |
There was a problem hiding this comment.
It seems unfortunate to have to annotate every unsafe function call. I wonder if it is possible to mark the whole block unsafe, like the following:
unsafe {
// do unsafe things here
}There was a problem hiding this comment.
We can use large unsafe blocks, but in #8450 (review) and for example #8455 (comment) @crepererum suggests to minimize the size of the unsafe blocks to help with unsafe code reviewing.
There was a problem hiding this comment.
Makes sense -- let's go with the more surgical approach then 👍
| ["tsn", tz] => { | ||
| DataType::Timestamp(TimeUnit::Nanosecond, Some(Arc::from(*tz))) | ||
| } | ||
| ["tss", tz] => DataType::Timestamp(TimeUnit::Second, Some(Arc::from(*tz))), |
There was a problem hiding this comment.
the choice of what rustfmt redoes seems somewhat arbitrary, but reasonable to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Splitting up #8227.
What changes are included in this PR?
Migrate
arrow-schemato Rust 2024Are these changes tested?
CI
Are there any user-facing changes?
Yes