Skip to content

[Variant] Add list support to unshred_variant #8514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Oct 2, 2025
Merged

[Variant] Add list support to unshred_variant #8514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0662e12
[Variant] Define and use unshred_variant function
scovich Sep 30, 2025
f276fb7
[Variant] Add list support to unshred_variant
scovich Sep 30, 2025
43f0b78
Merge remote-tracking branch 'oss/main' into unshred-variant-list
scovich Oct 1, 2025
bad0e2d
fmt
scovich Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fmt
  • Loading branch information
@scovich
scovich committed Oct 1, 2025
commit bad0e2dc6ab37db2b15894058f220778c9920b9d
21 changes: 12 additions & 9 deletions parquet-variant-compute/src/unshred_variant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,15 +223,18 @@ impl<'a> UnshredVariantRowBuilder<'a> {
value,
typed_value.as_list(),
)?),
DataType::LargeList(_) => Self::LargeList(
ListUnshredVariantBuilder::try_new(value, typed_value.as_list())?,
),
DataType::ListView(_) => Self::ListView(
ListUnshredVariantBuilder::try_new(value, typed_value.as_list_view())?,
),
DataType::LargeListView(_) => Self::LargeListView(
ListUnshredVariantBuilder::try_new(value, typed_value.as_list_view())?,
),
DataType::LargeList(_) => Self::LargeList(ListUnshredVariantBuilder::try_new(
value,
typed_value.as_list(),
)?),
DataType::ListView(_) => Self::ListView(ListUnshredVariantBuilder::try_new(
value,
typed_value.as_list_view(),
)?),
DataType::LargeListView(_) => Self::LargeListView(ListUnshredVariantBuilder::try_new(
value,
typed_value.as_list_view(),
)?),
DataType::FixedSizeList(_, _) => Self::FixedSizeList(
ListUnshredVariantBuilder::try_new(value, typed_value.as_fixed_size_list())?,
),
Expand Down
1 change: 0 additions & 1 deletion parquet/tests/variant_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ impl VariantTestCase {

let variant_data = self.load_variants();
let variant_array = self.load_parquet();
let variant_array = unshred_variant(&variant_array).unwrap();

// `load_parquet` returns shredded variant values, but the test expectations are provided as
// unshredded variant values. Unshred (failing for invalid input) so we can compare them.
Expand Down
Loading