ARROW-6780: [C++][Parquet] Support DurationType in writing/reading parquet (written as int64) #12449
Conversation
…rquet (written as int64)
| parquet_fields.push_back( | ||
| PrimitiveNode::Make("duration[us]", Repetition::REQUIRED, ParquetType::INT64)); | ||
| arrow_fields.push_back(::arrow::field("duration[us]", INT64, false)); |
There was a problem hiding this comment.
What is the purpose of this? It's just an INT64 field like any other, no?
There was a problem hiding this comment.
Ah, I initially wrote the test with duration type, but because this test is for the pure Parquet->Arrow schema conversion (without any usage of ARROW:schema), it failed and I changed it to int64. Which of course renders it useless as it's indeed just testing int64 type. Will remove.
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM, thank you @jorisvandenbossche !
|
Benchmark runs are scheduled for baseline = d33b6a5 and contender = 17fcbdb. 17fcbdb is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
No description provided.