-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47797: [CI][Python] Update Python installs for free-threaded wheel tasks #47993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlenkaF
wants to merge
26
commits into
apache:main
Choose a base branch
from
AlenkaF:gh-47797-free-threaded-installs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a28ad95
Update musllinux installs
AlenkaF 8570d78
Use default args
AlenkaF c561bdc
Update windows wheels dockerfiles to use MSIX
AlenkaF 49cfe39
Remove free threaded win wheels from services (only build, not test -…
AlenkaF d4826d6
Bring bach win free-threaded service and only use the same dockerfile
AlenkaF d07e66a
Update windows test wheels dockerfiles to use MSIX
AlenkaF 1394346
Try moving install of MSIX to base dockerfile
AlenkaF d0c0859
Add MSIX to the test base dockerfile also
AlenkaF 9551173
Use proper powershell syntax
AlenkaF eee6686
Try if curl works
AlenkaF ab6897c
Move curl command outside Poweshell
AlenkaF 417d15f
Change url and decouple choco and pymanager install
AlenkaF 1ca4c8b
Revert "Update windows test wheels dockerfiles to use MSIX"
AlenkaF 4e902a3
Remove pymanager install from base test dockerfile
AlenkaF 73ff8cd
Revert unnecessary changes on the choco install in base test
AlenkaF 5a5052a
Fix wrong tab
AlenkaF 8e20163
Update ci/docker/python-wheel-windows-vs2022-base.dockerfile
AlenkaF 04f1dd5
Remove duplicated rows
AlenkaF d7d7cce
Try removing defaults already parametered
AlenkaF 3c504dc
Remove mapping to patch versions
AlenkaF 05e1c79
Include python_variant suggestion
AlenkaF 2729bac
Add build_date arg
AlenkaF 1cdfcf0
Fix win dockerfile
AlenkaF 6655dc8
Fix error - win test still using choco not pymanager
AlenkaF bf5375f
Fix typo
AlenkaF ba38f43
Remove old comment
AlenkaF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 0 additions & 53 deletions
53
ci/docker/python-free-threaded-wheel-windows-vs2022.dockerfile
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do similar changes for
python-wheel-windows-test-vs2022.dockerfileand friends?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to make it work for the test group. Looks like a different underlying image might not be able to support this kind of
pymanagerinstall, but have no experience really =)More info on what issues I had:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, fair enough. Can you open an issue so that it can be investigated later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #48469