Skip to content

MINOR: Update null values documentation in csv.rst #48048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aiee wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −0
Open

MINOR: Update null values documentation in csv.rst #48048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7945ea3
Update null values documentation in csv.rst
Aiee Nov 4, 2025
a774f42
Address comments
Aiee Nov 6, 2025
0d47357
Address comments
Aiee Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/src/arrow/csv/options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ struct ARROW_EXPORT ConvertOptions {

/// Create conversion options with default values, including conventional
/// values for `null_values`, `true_values` and `false_values`
///
/// Default null values: see http://crossbow.voltrondata.com/pr_docs/48048/cpp/csv.html#nulls
Copy link
Member

@AlenkaF AlenkaF Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not link to the preview docs. Here, in the header file, we can actually add the list of the conventional null values. Then this section can be linked from the csv.html.

/// Default true values: `"1"`, `"True"`, `"TRUE"`, `"true"`,
/// Default false values: `"0"`, `"False"`, `"FALSE"`, `"false"`,
static ConvertOptions Defaults();

/// \brief Test that all set options are valid
Expand Down
Loading