[BEAM-11968] Bump com.google.cloud:libraries-bom to 19.0.0 #14218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing the isMtls() in google-http-client. Looks like it has been added since 1.38.0: https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java#L136 Original stacktrace: ``` java.lang.RuntimeException: Encountered checked exception when constructing an instance from factory method DataflowRunner#fromOptions(interface org.apache.beam.sdk.options.PipelineOptions) at org.apache.beam.sdk.util.InstanceBuilder.buildFromMethod (InstanceBuilder.java:233) at org.apache.beam.sdk.util.InstanceBuilder.build (InstanceBuilder.java:158) at org.apache.beam.sdk.PipelineRunner.fromOptions (PipelineRunner.java:55) at org.apache.beam.sdk.Pipeline.create (Pipeline.java:154) ... at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:64) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:282) at java.lang.Thread.run (Thread.java:832) Caused by: java.lang.NoSuchMethodError: 'boolean com.google.api.client.http.HttpTransport.isMtls()' at com.google.api.services.storage.Storage$Builder.chooseEndpoint (Storage.java:11151) at com.google.api.services.storage.Storage$Builder.<init> (Storage.java:11184) at org.apache.beam.sdk.extensions.gcp.util.Transport.newStorageClient (Transport.java:97) at org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create (GcsUtil.java:104) at org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create (GcsUtil.java:93) at org.apache.beam.sdk.options.ProxyInvocationHandler.returnDefaultHelper (ProxyInvocationHandler.java:605) at org.apache.beam.sdk.options.ProxyInvocationHandler.getDefault (ProxyInvocationHandler.java:546) at org.apache.beam.sdk.options.ProxyInvocationHandler.invoke (ProxyInvocationHandler.java:171) at com.sun.proxy.$Proxy41.getGcsUtil (Unknown Source) at org.apache.beam.sdk.extensions.gcp.storage.GcsPathValidator.verifyPathIsAccessible (GcsPathValidator.java:83) at org.apache.beam.sdk.extensions.gcp.storage.GcsPathValidator.validateOutputFilePrefixSupported (GcsPathValidator.java:53) at org.apache.beam.runners.dataflow.DataflowRunner.fromOptions (DataflowRunner.java:291) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:64) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.apache.beam.sdk.util.InstanceBuilder.buildFromMethod (InstanceBuilder.java:217) at org.apache.beam.sdk.util.InstanceBuilder.build (InstanceBuilder.java:158) at org.apache.beam.sdk.PipelineRunner.fromOptions (PipelineRunner.java:55) at org.apache.beam.sdk.Pipeline.create (Pipeline.java:154) ... at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:64) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:282) at java.lang.Thread.run (Thread.java:832) ```
Member
|
Most of the failures appear to be a mocking situation that is checking how many times a trivial method is called. Probably the mocking should be more flexible or we could find a non-mock way to test. Do you feel able to go and adjust the mocks? |
Contributor
Author
|
@kennknowles I tried to debug the logs, I think it has to do with some missing licenses, but didn't get it running locally. @pabloem do you have any pointers? :) |
Member
|
sorry that I missed this. Rerunning things... |
Member
|
Run Java PreCommit |
Member
|
Run Java_Examples_Dataflow PreCommit |
Contributor
|
I have #14527 for the libraries-bom 20.0.0, which brings google-http-client 1.39.2 |
4 tasks
Member
|
ok closing for the 20.0.0 update instead. @Fokko I hope that's fine ^^' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing the isMtls() in google-http-client. Looks like it has been added since 1.38.0:
https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java#L136
Original stacktrace:
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-11968] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.