Add read failed log for ledger checker.#4010
Merged
StevenLuMT merged 2 commits intoapache:masterfrom Jul 7, 2023
Merged
Conversation
Member
Author
|
rerun failure checks |
zymap
approved these changes
Jul 3, 2023
hangc0276
approved these changes
Jul 3, 2023
wenbingshen
approved these changes
Jul 3, 2023
StevenLuMT
requested changes
Jul 3, 2023
Member
StevenLuMT
left a comment
StevenLuMT
left a comment
There was a problem hiding this comment.
What is the reason for modifying the fifth parameter of bookieClient.readEntry?
I couldn't see it's motivation in this PR
Member
Author
In the callback, we need to print the bookie. So we need the bookie as the ctx. |
Member
@StevenLuMT Can you help take a look at this comment? Thanks. |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Add read failed log for ledger checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
The ledger checker will try to read entries from the bookie. If the read failed, mark the ledger as under-replicated.
For users, they didn't know the reason why the ledger mark as under-replicated. Is it because the entry is missing, the ledger does not exist, or because the bookie is under heavy load and the read request times out?
So here we add debug log for ledger checker. If read failed, log the error code.