Fix bug of negative JournalQueueSize#4077
Merged
hangc0276 merged 2 commits intoapache:masterfrom Oct 26, 2023
Merged
Conversation
horizonzy
approved these changes
Sep 11, 2023
Member
horizonzy
left a comment
horizonzy
left a comment
There was a problem hiding this comment.
Nice catch. It solves my confusion
dlg99
approved these changes
Oct 16, 2023
yangl
pushed a commit
to yangl/bookkeeper
that referenced
this pull request
Dec 11, 2023
### Motivation While shouldRolloverJournal is true，the QueueEntry qe is not added to the toFlush queue but we decrease the JournalQueueSize incorrectly. ### Changes Decrease the JournalQueueSize after correct NonNull check of qe.
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jan 18, 2024
### Motivation While shouldRolloverJournal is true，the QueueEntry qe is not added to the toFlush queue but we decrease the JournalQueueSize incorrectly. ### Changes Decrease the JournalQueueSize after correct NonNull check of qe. (cherry picked from commit 85d7bb3)
gaozhangmin
pushed a commit
to gaozhangmin/bookkeeper
that referenced
this pull request
Feb 20, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation While shouldRolloverJournal is true，the QueueEntry qe is not added to the toFlush queue but we decrease the JournalQueueSize incorrectly. ### Changes Decrease the JournalQueueSize after correct NonNull check of qe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
While shouldRolloverJournal is true，the QueueEntry qe is not added to the toFlush queue but we decrease the JournalQueueSize incorrectly.
Changes
Decrease the JournalQueueSize after correct NonNull check of qe.