Skip to content

Migrate deprecated commons-configuration 1.x to commons-configuration 2.x#4604

Merged
merlimat merged 13 commits intoapache:masterfrom
lhotari:lh-migrate-to-commons-configuration2
May 26, 2025
Merged

Migrate deprecated commons-configuration 1.x to commons-configuration 2.x#4604
merlimat merged 13 commits intoapache:masterfrom
lhotari:lh-migrate-to-commons-configuration2

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented May 23, 2025

commons-configuration 1.x is deprecated and won't be updated. There's a low severity CVE-2025-46392 in commons-configuration 1.x.

This PR migrates the commons-configuration 1.x usage in BookKeeper to use commons-configuration 2.x
There's also changes to migrate from commons-lang to commons-lang3.

@lhotari lhotari force-pushed the lh-migrate-to-commons-configuration2 branch 3 times, most recently from f5e0d38 to fe8c635 Compare May 23, 2025 14:26
@lhotari lhotari force-pushed the lh-migrate-to-commons-configuration2 branch from fe8c635 to de1f23c Compare May 23, 2025 14:40
@lhotari lhotari changed the title [WIP] Migration to commons-configuration2 and commons-lang3 Migrate deprecated commons-configuration 1.x to commons-configuration 2.x May 23, 2025
@lhotari lhotari requested a review from merlimat May 23, 2025 18:48
@lhotari lhotari marked this pull request as ready for review May 23, 2025 18:52
@merlimat merlimat merged commit 5b0ae75 into apache:master May 26, 2025
25 checks passed
merlimat pushed a commit that referenced this pull request May 26, 2025
… 2.x (#4604)

* Migration to commons-configuration2 and commons-lang3

* Change test that breaks with commons configuration 2

* Add commons-beanutils dependency

* Revert "Change test that breaks with commons configuration 2"

This reverts commit 073c267.

* Fix ConfigKeyTest

* Configure list handling to match commons-configuration 1.x default behavior

* Fix the issue in using the API to configure defaults

* Configure list delimiter handler also for distributedlog's ConfigurationSubscription

* Address issue with system properties being null

* Use list delimiter handler in DistributedLogConfiguration too

* Fix spotbugs check

* Fix ConfigurationTest

- system properties are read when ServerConfiguration gets initialized

* Fix checkstyle
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jun 30, 2025
…ns.configuration2, base on Migrate deprecated commons-configuration 1.x to commons-configuration 2.x apache/bookkeeper#4604
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jun 30, 2025
…ns.configuration2, base on Migrate deprecated commons-configuration 1.x to commons-configuration 2.x apache/bookkeeper#4604
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jun 30, 2025
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jul 1, 2025
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jul 2, 2025
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jul 3, 2025
StevenLuMT added a commit to StevenLuMT/pulsar that referenced this pull request Jul 4, 2025
priyanshu-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 11, 2025
… 2.x (apache#4604)

* Migration to commons-configuration2 and commons-lang3

* Change test that breaks with commons configuration 2

* Add commons-beanutils dependency

* Revert "Change test that breaks with commons configuration 2"

This reverts commit 073c267.

* Fix ConfigKeyTest

* Configure list handling to match commons-configuration 1.x default behavior

* Fix the issue in using the API to configure defaults

* Configure list delimiter handler also for distributedlog's ConfigurationSubscription

* Address issue with system properties being null

* Use list delimiter handler in DistributedLogConfiguration too

* Fix spotbugs check

* Fix ConfigurationTest

- system properties are read when ServerConfiguration gets initialized

* Fix checkstyle

(cherry picked from commit 542ea09)
sandeep-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 22, 2025
… 2.x (apache#4604)

* Migration to commons-configuration2 and commons-lang3

* Change test that breaks with commons configuration 2

* Add commons-beanutils dependency

* Revert "Change test that breaks with commons configuration 2"

This reverts commit 073c267.

* Fix ConfigKeyTest

* Configure list handling to match commons-configuration 1.x default behavior

* Fix the issue in using the API to configure defaults

* Configure list delimiter handler also for distributedlog's ConfigurationSubscription

* Address issue with system properties being null

* Use list delimiter handler in DistributedLogConfiguration too

* Fix spotbugs check

* Fix ConfigurationTest

- system properties are read when ServerConfiguration gets initialized

* Fix checkstyle

(cherry picked from commit 542ea09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments