Do not overwrite async timeout 503 with sendError(500) in afterProcess#1778
Merged
Merged
Conversation
When Spring's async timeout handler sends 503, the executor thread's afterProcess() catches AsyncRequestNotUsableException from writeResponse() and falls through to sendError(500), overwriting the 503. Skip the sendError(500) fallback when the failure is AsyncRequestNotUsableException.
Croway
force-pushed
the
fix/async-request-not-usable-overwrite
branch
from
44d5241 to
8ff8351
Compare
Contributor
Author
|
The failures are expected, #1777 this PR fixes those failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
afterProcess()catchesAsyncRequestNotUsableExceptionfromwriteResponse()and falls through tosendError(500), overwriting the 503AsyncRequestNotUsableExceptioninafterProcess()andservice()and skip thesendError(500)fallbackspring-webTest plan
SpringBootPlatformHttpAsyncNotUsableTestwith two test methods:testAsyncNotUsableShouldNotOverwriteWith500— verifies no 500 whenAsyncRequestNotUsableExceptionis throwntestRegularIOExceptionStillReturns500— verifies regularIOExceptionstill produces 500