Skip to content

refactor: small syntax changes#64

Merged
erisu merged 3 commits intoapache:masterfrom
erisu:refactor/syntax-changes
Apr 17, 2020
Merged

refactor: small syntax changes#64
erisu merged 3 commits intoapache:masterfrom
erisu:refactor/syntax-changes

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented Apr 16, 2020

Motivation, Context & Description

  • Modernizing Syntax
    • var to let & const
    • arrow functions

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Apr 16, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 16, 2020

Codecov Report

Merging #64 into master will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   89.70%   89.55%   -0.16%     
==========================================
  Files           1        1              
  Lines          68       67       -1     
==========================================
- Hits           61       60       -1     
  Misses          7        7              
Impacted Files Coverage Δ
index.js 89.55% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a399529...3bc4b2b. Read the comment docs.

@erisu erisu force-pushed the refactor/syntax-changes branch from 96fe917 to 3bc4b2b Compare April 17, 2020 09:47
@erisu erisu merged commit 5f24bdb into apache:master Apr 17, 2020
@erisu erisu deleted the refactor/syntax-changes branch April 17, 2020 09:54
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (a399529) to head (3bc4b2b).
⚠️ Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   89.70%   89.55%   -0.16%     
==========================================
  Files           1        1              
  Lines          68       67       -1     
==========================================
- Hits           61       60       -1     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants